java - Random number keeps giving the number 1 -

-

since added while loop little rock,paper , scissors game keeps giving me number 1. 

package steenpapierschaar1;  import java.util.scanner;  /**  *  * @author t  */ public class steenpapierschaar1 {      /**      * @param args command line arguments      */     public static void main(string[] args) {          int rock = 1 ;   // waarde van rock         int paper = 2;  // waarde van paper         int scissor = 3;// waarde van scissor         int ai = 1 + (int) (math.random() *3);// maakt int ai een random getal nog niet af moet een range in komen         scanner keyboard = new scanner (system.in);// naam scanner input         boolean playing = true;         string answer, answer2 = null;           while(playing = true){             system.out.println("choose 1 rock, 2 paper , 3 scissor"); // string met keuze voor user             int userchoice = keyboard.nextint();// waarde van userchoice              if (ai == 1 && userchoice == 2 || ai == 2 && userchoice == 3 || ai == 3 && userchoice == 1) { // als de speler elke keer 1x hoger heeft wint hij de ronde                 system.out.println("you win");// outprint met dat je gewonnen hebt en wat de computer doet                 if (ai == 1)                     system.out.println("the computer did rock");                 if (ai == 2)                     system.out.println("the computer did paper");                 if (ai == 3)                     system.out.println("the computer did scissors");               }              else if (ai == 1 && userchoice == 1 || ai == 2 && userchoice == 2 || ai == 3 && userchoice == 3) {                 system.out.println("draw");                 if (ai == 1)                     system.out.println("the computer did rock");                 if (ai == 2)                     system.out.println("the computer did paper");                 if (ai == 3)                     system.out.println("the computer did scissors");             }              else if (ai == 1 && userchoice == 3 || ai == 2 && userchoice == 1 || ai == 3 && userchoice == 2){                 system.out.println("you lose");                 if (ai == 1)                     system.out.println("the computer did rock");                 if (ai == 2)                     system.out.println("the computer did paper");                 if (ai == 3)                     system.out.println("the computer did scissors");             }                        }             } }

there few problems in code. have few unused variables 

int rock = 1 ;  // waarde van rock int paper = 2;  // waarde van paper int scissor = 3;// waarde van scissor

which should 

final int rock = 1; // waarde van rock final int paper = 2; // waarde van paper final int scissors = 3;// waarde van scissor

and used 

if (ai == rock) ...

other problem while (playing == true) notice = assignment operator == comparing operator. in loop assigning true playing evaluated true.

to avoid such problems mistake write = instead of == use 

while (playing){  }

btw should ask after each play if user want continue/quit game. can checking values -1 can represent "quit".

another problem never reassign value of ai inside loop value can't change , same @ start of program. maybe move 

int ai = 1 + (int) (math.random() * 3);

at start of while loop let ai new value.

btw2 instead of math.random()*3 kind of cryptic can use random class , nextint(n) method random integer in range [0; n)

  • 0 (including)
  • n (excluding).

which can interpreted [0; n-1]. code 

random r = new random(); while(..){     int ai = r.nextint(3) + 1; // +1 because want move range [0; 2] [1; 3]     ... }

it looks invoking

if (ai == 1)     system.out.println("the computer did rock"); if (ai == 2)     system.out.println("the computer did paper"); if (ai == 3)     system.out.println("the computer did scissors");

in each of win/draw/lose conditions. in case can move out of each of these blocks 

if (win conditions){     print win }else if (draw condition){     print draw }else if (lose condition){     print lose } <move code drawing computer hand here>

draw condition looks overly complex. looks draw achieved when ai , userchoice equal simple 

if (ai == userchoice)

could replace

if (ai == 1 && userchoice == 1 || ai == 2 && userchoice == 2 || ai == 3 && userchoice == 3)

you can simplify other conditions using modulo % operator.


Comments

Post a Comment

Popular posts from this blog

c++ - No viable overloaded operator for references a map -

-
i trying use map can make tag names reference number. when try , use it, in code error (6 in total every time reference map): src/main.cpp:25:45: error: no viable overloaded operator[] type 'std::map<std::string, std::string>' const char* idcs = node.child_value(tagmap[3]); this code: #include "pugi/pugixml.hpp" #include <iostream> #include <string> #include <map> int main() { pugi::xml_document doca, docb; std::map<std::string, pugi::xml_node> mapa, mapb; std::map<std::string, std::string> tagmap {{"1", "data"}, {"2", "entry"}, {"3", "id"}, {"4", "content"}}; if (!doca.load_file("a.xml") || !docb.load_file("b.xml")) { std::cout << "can't find input files"; return 1; } (auto& node: doca.child(tagmap[1]).children(tagmap[2])) { co
Read more

java - Custom OutputStreamAppender not run: LOGBACK: No context given for <MYAPPENDER> -

-
i wish write custom appender on basis of outputstreamappender . wrote following class package tests; import java.io.ioexception; import java.io.outputstream; import ch.qos.logback.core.outputstreamappender; public class myappender<e> extends outputstreamappender<e> { public myappender() { system.out.println("myappender created"); setoutputstream(new outputstream() { @override public void write(int b) throws ioexception { throw new unsupportedoperationexception(); } }); } } then wrote following runner: package tests; import org.slf4j.loggerfactory; import ch.qos.logback.classic.logger; public class runner { private static final logger log = (logger) loggerfactory.getlogger(runner.class); public static void main(string[] args) { //log.addappender(new myappender<iloggingevent>()); log.info("hello world"); } } finall
Read more

java - Cannot secure connection using TLS -

-
i'm trying establish secure socket connection between java client applet (built jdk 1.7.0_75-b13) , vc++ server application. as test vehicle, used vc++ client/server sample found in msdn forums, modified use schannel , able establish socket using cipher suite tls_rsa_with_aes_128_cbc_sha. works of tls 1.0/1.1/1.2. when try opening socket java applet same server application, connection rejected server reporting following: tls 1.0 acceptsecuritycontext failed: 0x80090327 tls 1.1 acceptsecuritycontext failed: 0x80090331 tls 1.2 acceptsecuritycontext failed: 0x80090331 this java code used create socket: debugprint("setting secure connection"); sslsocketfactory sslsocketfactory = (sslsocketfactory) sslsocketfactory.getdefault(); sslsocket sslsocket = (sslsocket) sslsocketfactory.createsocket("127.0.0.1", socketnumber); debugprint("starting handshake"); sslsocket.settcpnodelay(true); sslsocket.setsolinger(false, 0); sslsocket.s
Read more